feat: support workspaces #100
Conversation
|
Hi @WataruNishimura!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
WataruNishimura
changed the title
Thanks for comments! Sure I'll try it. |
WataruNishimura
changed the title
| @@ -39,20 +39,45 @@ function findPackageJson(startDir) { | |||
| return null; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We can write this as a function(possible isRootWorkspace()), something like:
function isRootWorkspace(packageJsonPath){
const pkg = JSON.parse(...)
if(pkg.private === true && pkg.workspaces !== void 0) return true;
return fs.existsSync(path.join(packageJsonPath, "../pnpm-workspace.yaml");
}it can be evalutated in the constructor, so you can just use it when you need it:
this.isRootWorkspace = isRootWorkspace();
|
@WataruNishimura are you still working on this? |
|
Closing because there hasn't been activity for 30 days. If you're still interested in submitting this code, please feel free to resubmit. |
Relative issues
#96 (I submitted this issue)
What I did
findPnpmWorkspaceYaml()to findpnpm-workspace.yamlpnpmfinds this, pnpm recognize as workspace root the directory even the file is empy.-wtoinstallSyncSaveDev()